Page 1 of 2
Mythbuntu theme
Posted: Wed Jun 06, 2018 7:02 pm
by wesnewell
I've never liked the idea of just 7 channel listings and 2 hours in the guide so a few years back I modified it for 14 listing and 3 hours for the main program guide <window name="programguide">. That has worked great so far but I wanted 4 hours, so modified the latest mythnutu theme for 14 channels with 4 hours for both <window name="programguide"> and <window name="programguide-video">. This also works great now with the mythtv version 29.1. Modified files are schedule-ui.xml and base.xml (which I only added some new font definitions to).
preview.jpg
Re: Mythbuntu theme
Posted: Wed Jun 06, 2018 8:55 pm
by Steve Goodey
Re: Mythbuntu theme
Posted: Thu Jun 07, 2018 7:35 pm
by wesnewell
I've contacted him by email. Add a picture of the guide in first post, Find this in fe log when I try to past hour 3. Have no clue what it means. Maybe a limit of the fe, and not a theme problem?
Jun 7 13:54:30 mythfe0 mythfrontend.real: mythfrontend[16806]: I CoreContext guidegrid.cpp:894 (gestureEvent) GuideGrid: Guide Gesture event #025
Re: Mythbuntu theme
Posted: Sat Jun 09, 2018 6:52 am
by paulh
I've got a feeling of déjà vu
viewtopic.php?t=1358&p=6554
I know Thomas got some stick when he made changes to the Mythbuntu theme last time so he may be reluctant to make such a drastic change. You can't assume what you want is what every user wants. He did make a classic version of the theme minus most of the new changes to keep the mob who don't like changes happy.
You'll have to bug Roger to complete his zoomable guide grid patch mentioned on the other thread, or dare I say it help him finish it.
Re: Mythbuntu theme
Posted: Sat Jun 09, 2018 2:11 pm
by wesnewell
I'm just trying to get the 4 hour version to work right. Any idea what the log post above means? the latest version can be found here for anyone interested.
viewtopic.php?f=7&t=252#p6403
Re: Mythbuntu theme
Posted: Sun Jul 08, 2018 11:47 am
by paulh
wesnewell wrote: ↑Sat Jun 09, 2018 2:11 pm
I'm just trying to get the 4 hour version to work right. Any idea what the log post above means? the latest version can be found here for anyone interested.
viewtopic.php?f=7&t=252#p6403
The problem with having more than 3 hours shown in the guide grid should now be fixed in master and 0.29-fixes.
I'll leave the Ubuntu theme changes for Thomas to decide.
Re: Mythbuntu theme
Posted: Mon Jul 09, 2018 7:06 am
by wesnewell
paulh wrote: ↑Sun Jul 08, 2018 11:47 am
The problem with having more than 3 hours shown in the guide grid should now be fixed in master and 0.29-fixes.
I'll leave the Ubuntu theme changes for Thomas to decide.
Fixed isn't exactly the word I would use. The word I'd use does start with an F though. After just running the software updater to get all the new mythtv stuff, all of the themes are screwed up. And i mean all of them, even the original unmodified ones. Here's the guide from the unmodified mythbuntu theme. And the guides are screwed up in every theme.
Screenshot.jpg
Re: Mythbuntu theme
Posted: Mon Jul 09, 2018 8:48 am
by paulh
The patch has been sitting in master since 20th June and no one reported any problems so I just cherry picked it into 29.0-fixes assuming it should work OK there to since I've no way to easily test fixes. There must be some differences between the two that I am not aware of.
I've never used the Ubuntu theme can you elaborate on what is wrong I assume it dosen't normally look like the screen shot?
Re: Mythbuntu theme
Posted: Mon Jul 09, 2018 2:05 pm
by dizygotheca
Do you mean in every theme the guide shows just 4 (misaligned) channels ?
Looks like a simple typo/backspace during the backport. The commit in Master is ok
Code: Select all
diff --git a/mythtv/libs/libmythui/mythuiguidegrid.h b/mythtv/libs/libmythui/mythuiguidegrid.h
index 8b508770b7..ec3e400045 100644
--- a/mythtv/libs/libmythui/mythuiguidegrid.h
+++ b/mythtv/libs/libmythui/mythuiguidegrid.h
@@ -14,7 +14,13 @@
-#define MAX_DISPLAY_CHANS 40
+
+
+// max number of channels to display in the guide grid
+#define MAX_DISPLAY_CHANS 4
+
Re: Mythbuntu theme
Posted: Mon Jul 09, 2018 3:12 pm
by wesnewell
dizygotheca wrote: ↑Mon Jul 09, 2018 2:05 pm
Do you mean in every theme the guide shows just 4 (misaligned) channels ?
That's what I mean. Still works ok on the frontends that I haven't updated yet. So what should I do to fix this?
Re: Mythbuntu theme
Posted: Mon Jul 09, 2018 3:57 pm
by paulh
Ah! well spotted dizygotheca
There was a conflict in the cherry pick so I had to do a little copy/paste and somehow screwed it up. All fixed now I think
Re: Mythbuntu theme
Posted: Mon Jul 09, 2018 4:15 pm
by wesnewell
paulh wrote: ↑Mon Jul 09, 2018 3:57 pm
Ah! well spotted dizygotheca
There was a conflict in the cherry pick so I had to do a little copy/paste and somehow screwed it up. All fixed now I think
So what do I do to fix mine? There are no new updates in the repo.
Re: Mythbuntu theme
Posted: Mon Jul 09, 2018 4:26 pm
by Steve Goodey
Give it 24 hours.
Re: Mythbuntu theme
Posted: Tue Jul 10, 2018 5:23 am
by wesnewell
New update came in and it fixes everything. Now my 4 hour guide works as it should. Thanks to all for getting this fixed.
Re: Mythbuntu theme
Posted: Wed Jul 11, 2018 5:16 pm
by wesnewell
Since it was fairly easy decided to do one for monochrome theme too. If interested you can get it here.
viewtopic.php?f=7&p=13299#p13082
monochrome.jpg